[Webkit-unassigned] [Bug 39792] [chromium] Accessibility focus change notifications should be triggered from ChromeClientImpl::focusedNodeChanged

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39792


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57171|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-05-28 10:15:51 PST ---
(From update of attachment 57171)
WebKit/chromium/src/ChromeClientImpl.cpp:195
 +      WebURL focusUrl;
nit: webkit style is focusURL (see the Names section at
http://webkit.org/coding/coding-style.html).

WebKit/chromium/src/ChromeClientImpl.cpp:201
 +          hitTest.setURLElement(reinterpret_cast<Element*>(node));
nit: this should use static_cast since an Element "is a" Node.

WebKit/chromium/src/ChromeClientImpl.cpp:211
 +        ASSERT_NOT_REACHED();
nit: indent by 4 spaces

otherwise, LGTM.  please correct those nits, and then good to commit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.