[Webkit-unassigned] [Bug 25703] Stack overflow crash rendering element with mega-huge number of background layers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25703





--- Comment #5 from hans at chromium.org  2010-05-28 09:00:34 PST ---
(In reply to comment #4)
> (From update of attachment 57315 [details])
> I'm not qualified to officially review this, but it seems fairly sound.  A couple nits though.
> 
> 
> LayoutTests/css3/many-background-layers.html:12
>  +        for (var i = 0; i < 100000; i++)
> Nit: ++i
> Nit: Maybe put 100000 in a constant and initialize that constant with 100*1000 to make it easier to read?
Done.

> WebCore/rendering/RenderBox.cpp:765
>  +      for (size_t i = layers.size(); i > 0; i--)
> nit: --i
Done.

>
> This isn't the most elegant code, but I don't have a better answer off the top of my head.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.