[Webkit-unassigned] [Bug 38156] many webkit-patch commands fail in a non-svn tracking git checkout

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38156





--- Comment #10 from Chris Jerdonek <cjerdonek at webkit.org>  2010-05-28 06:41:31 PST ---
(In reply to comment #9)
> > +++ b/WebKitTools/Scripts/webkitpy/common/checkout/scm.py
> >      # Git-specific methods:
> > +    def _branch_exists(self, branch_ref):
> > +        return self.run(['git', 'show-ref', '--quiet', '--verify', branch_ref], return_exit_code=True) == 0
> 
> Question: do all git commands also accept a fully-qualified reference path (i.e.
> branch "ref") wherever a simple branch name is accepted?
> 
> Would it be better to call this _reference_exists()?  The documentation for
> git-show-ref calls the values that show-ref displays "references".  See below
> for more comments.

Similarly, the parameter name should probably also be changed if the method name is changed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.