[Webkit-unassigned] [Bug 39588] Provide implementation of DeviceOrientation and hook into DOMWindow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39588





--- Comment #3 from Jeremy Orlow <jorlow at chromium.org>  2010-05-28 06:28:30 PST ---
(From update of attachment 57101)
Drive by comments (I'm not qualified to review this):

WebCore/page/DOMWindow.cpp:1396
 +      if (eventType == eventNames().deviceorientationEvent && frame() && frame()->page())
maybe this should be an else if joined with the previous block?  Could go either way about what's best.  Obviously either is technically correct.  I could go either way.

WebCore/page/DOMWindow.cpp:1378
 +      if (eventType == eventNames().deviceorientationEvent && frame() && frame()->page())
Ditto

WebCore/dom/DeviceOrientation.cpp:45
 +      ASSERT(!m_listeners.contains(window));
If you add multiple event listeners to one window, does it call addEventListener multiple times?  I would have thought so...in which case, this assumption wouldn't be true.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.