[Webkit-unassigned] [Bug 39854] Refactor platform depedent editing behavior code out of Settings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39854





--- Comment #2 from Ojan Vafai <ojan at chromium.org>  2010-05-27 15:27:42 PST ---
(From update of attachment 57277)
This is close to what I had in mind. Except I was picturing EditingBehavior that is a member of Settings. There's a lot of plumbing to get at Settings (e.g. Frame and Document already have settings methods). Actually, I was originally picturing something more like WebCore/editing/htmlediting.h, but the fact that the behavior is runtime settable means we can't just use a bunch of helper functions like that. I think we probably don't need the cpp file though. These methods should all be really dumb if-statements that check the editing behavior and return booleans.

That's all nit-picking though. What you have seems fine to me. I defer to darin here though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.