[Webkit-unassigned] [Bug 35530] Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 27 14:40:59 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=35530





--- Comment #35 from Ojan Vafai <ojan at chromium.org>  2010-05-27 14:40:54 PST ---
(From update of attachment 51713)
Sorry you had to wait so long to get a followup review here. I ran the includes in question through sort and it looks like what you have is correct. So, I can r+ this once you fix the ChangeLog descriptions and update this patch to tip of tree.

WebCore/ChangeLog:8
 +          No new tests. (OOPS!)
Please remove this line and add a line explaining that these are style cleanups in preparation for fixing bug 35530.

WebKit/qt/ChangeLog:7
 +  
Please add a line explaining that these are style cleanups in preparation for fixing bug 35530.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list