[Webkit-unassigned] [Bug 32123] cursor movement and text selection does not work well if a block is followed by an inline

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 27 14:41:02 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=32123





--- Comment #9 from Dave Hyatt <hyatt at apple.com>  2010-05-27 14:41:00 PST ---
(From update of attachment 51722)
In terms of the visual rendering of selection, what you're supposed to have is a bunch of leaf elements, which are replaced elements and text, the line boxes, and then the containing blocks for those elements, which are responsible for line/block gap filling.  RenderInlines shouldn't really be examined at all for selection state, and they certainly shouldn't have it set on themselves.

We should add ASSERTs when RenderInline's selection state is set and see why this happened.  I'm guessing maybe it got set because it was m_selectionStart or m_selectionEnd, but it would be good to know.

If we want RenderInline selectionState to be accurate, then everyone would need to start propagating selection state up through inlines.  That could seriously slow down selection performance.  If you look at all of the selectionState methods, they all skip intermediate inlines and jump right up to the RenderBlock.

It might be ok for RenderInline to have questionable accuracy but still propagate, but that seems kind of weird to me.  Maybe it would be ok though.  I'd really like to understand why this happened in the first place though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list