[Webkit-unassigned] [Bug 39288] Geolocation causes DOMWindow to leak if position requests are in progress when the page is navigated away

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39288





--- Comment #18 from Steve Block <steveblock at google.com>  2010-05-27 13:59:34 PST ---
> That's exactly what concerns me. These requests won't be stopped, because FrameLoader::stop() won't be called again.
> So, the problem that was fixed by r59859 can be re-introduced.
It's true that a crash is possible, but I don't think this is introduced by this patch. I don't think the fix in r59859 fully solved
the problem. If I understand things correctly, stopping ongoing requests in disconnectFrame() isn't sufficient because
Geolocation activity can be started after this point by code in same-origin frames. I think that as well as stopping ongoing
requests, we would need to make sure that no new requests are started after disconnectFrame() has been called.

After this patch, we suffer from the same problem, but the critical point is now stop() rather than disconnectFrame().

Does that make sense? Apologies if not, I'm new to the loader code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.