[Webkit-unassigned] [Bug 39757] Add TransformActionEvent support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39757





--- Comment #8 from Ben Murdoch <benm at google.com>  2010-05-27 07:18:49 PST ---
(From update of attachment 57194)
Looks like a good start! I'm not a reviewer but some comments after trying the first patch on Android:

WebCore/dom/Document.idl:313
 +          attribute [DontEnum,Conditional=TRANSFORMACTION_EVENTS,EnabledAtRuntime] EventListener ontransformactionstart;
If you want to make this a runtime enabled feature then you also need to add methods to the RuntimeEnabledFeatures class
in WebCore/bindings/generic/RuntimeEnabledFeatures.h|cpp - see how touch does it for an example.
I think as the feature is protected by a compile time guard it is safe to default the runtime flag to true.

And a few whitespace nits that my patch tool complained about:

WebCore/dom/TransformActionEvent.cpp:49
 +      int screenY, int clientX, int clientY, bool ctrlKey, bool altKey, 
Trailing whitespace

WebCore/dom/TransformActionEvent.cpp:51
 +      int translateSpeedX, int translateSpeedY, float scale, float scaleSpeed, 
Trailing whitespace

WebCore/dom/TransformActionEvent.h:35
 +      static PassRefPtr<TransformActionEvent> create(const AtomicString& type, 
Trailing whitespace

WebCore/dom/TransformActionEvent.h:36
 +          bool canBubble, bool cancelable, PassRefPtr<AbstractView> view, 
Trailing whitespace

WebCore/dom/TransformActionEvent.h:43
 +              view, screenX, screenY, pageX, pageY, ctrlKey, altKey, shiftKey, 
Trailing whitespace

Would you also mind adding the new files to the Android makefiles? TransformActionEvent.cpp should go in
WebCore/Android.mk and the idl should go into WebCore/Android.derived.v8bindings.mk and
WebCore/Android.derived.jscbindings.mk.

Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.