[Webkit-unassigned] [Bug 39735] Implement CSS Paged Media Module Level3's Page Breaks (master bug)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39735





--- Comment #3 from Shinichiro Hamaji <hamaji at chromium.org>  2010-05-27 06:12:17 PST ---
(From update of attachment 57215)
I didn't look at this patch closely yet, but I'd like to put some comments and questions.

WebCore/page/PrintContext.cpp:254
 +      // TODO: Check whether there is a gap between parent and child.
We use FIXME instead of TODO.

WebCore/page/PageBreak.h:37
 +  
Unnecessary blank line?

LayoutTests/printing/script-tests/page-break-after-avoid.js:7
 +      createBlockWithRatioToPageHeight("page2-1", 0.3).style.pageBreakAfter = "avoid";;
s/;;/;/

WebCore/page/PrintContext.cpp:118
 +      root->setPrintContext(this);
Cannot we call setPrintContext in PrintContext::begin and PrintContext::end ?

WebCore/page/PrintContext.cpp:420
 +          score -= 2;
Maybe it would be better to add a constant for this 2.

WebCore/rendering/RenderView.h:213
 +      PrintContext* m_printContext;
Cannot we remove Document::m_printing by adding this member?

WebCore/rendering/RenderLineBoxList.cpp:190
 +      int lineTotal = 0;
Why don't you put lineTotal calculation below line 198 ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.