[Webkit-unassigned] [Bug 27443] [Gtk] Combobox should support "find-as-you-type" search

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27443


Alexander Butenko <a.butenka at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |a.butenka at gmail.com




--- Comment #10 from Alexander Butenko <a.butenka at gmail.com>  2010-05-27 05:56:23 PST ---
(In reply to comment #6)
> Created an attachment (id=57170)
 --> (https://bugs.webkit.org/attachment.cgi?id=57170) [details]
> Find-as-you-type proposed patch
> 
> Added searching inside indented "tree lists".
> This should complete the patch, it nows seems to fix the bug.

Im not a reviewer, but as a quick followup:

--- a/WebCore/platform/PopupMenu.h
+++ b/WebCore/platform/PopupMenu.h
@@ -50,7 +50,10 @@ typedef struct _GtkMenuItem GtkMenuItem;
 typedef struct _GtkWidget GtkWidget;
 #include "GRefPtrGtk.h"
 #include <wtf/HashMap.h>
+#include <gdk/gdk.h>
 #include <glib.h>
+#include <list>
+#include <string>


u cant include gdk.h in platform independent files without platform guard coz it will break all the platforms except gtk.

patch is awesome, will simplify life a lot.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.