[Webkit-unassigned] [Bug 38851] Large SVG rect with shadow fails to render

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38851





--- Comment #5 from Nikolas Zimmermann <zimmermann at kde.org>  2010-05-27 00:48:00 PST ---
(From update of attachment 57192)
Damn, my comment disappeared, retyping, but not that explicit anymore :( Anyhow, r- because of some nitpicks:

LayoutTests/svg/filters/shadow-on-rect-large.svg:2
 +  <rect x="0" y="0" width="2147483647" height="300" fill="green" style="-webkit-svg-shadow:5px 5px 5px grey;"/>
Please add a comment here, stating that it passes if it does not crash, and maybe add the bug numbe.r

The code change itself is fine, though it could be optimized. How about just using:
repaintRect.move(shadowLeft, shadowRight);
repaintRect.setSize(repaintRect.size() + FloatSize(shadowRight - shadowLeft, shadowBottom - shadowTop));

That would save any intermediate int/float value, and is easier to read IMHO.
What do you think?

Cheers,
Niko

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.