[Webkit-unassigned] [Bug 27443] [Gtk] Combobox should support "find-as-you-type" search

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27443


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #7 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-05-26 15:36:56 PST ---
Attachment 57170 did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/platform/gtk/PopupMenuGtk.cpp:34:  Streams are highly discouraged.  [readability/streams] [3]
WebCore/platform/gtk/PopupMenuGtk.cpp:168:  Extra space before ( in function call  [whitespace/parens] [4]
WebCore/platform/gtk/PopupMenuGtk.cpp:211:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/platform/gtk/PopupMenuGtk.cpp:231:  Use 0 instead of NULL.  [readability/null] [5]
WebCore/platform/gtk/PopupMenuGtk.cpp:243:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/platform/gtk/PopupMenuGtk.cpp:262:  Use 0 instead of NULL.  [readability/null] [5]
WebCore/platform/gtk/PopupMenuGtk.cpp:273:  Missing space before {  [whitespace/braces] [5]
WebCore/platform/PopupMenu.h:53:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 8 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.