[Webkit-unassigned] [Bug 39446] Video elements show no video on Windows machines that do not support accelerated compositing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39446


Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57138|review?                     |review+
               Flag|                            |




--- Comment #12 from Sam Weinig <sam at webkit.org>  2010-05-26 14:37:58 PST ---
(From update of attachment 57138)
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog	(revision 60251)
> +++ WebCore/ChangeLog	(working copy)
> @@ -1,3 +1,23 @@
> +2010-05-26  Jer Noble  <jer.noble at apple.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +		Video elements show no video on Windows machines that do not support accelerated compositing
> +		https://bugs.webkit.org/show_bug.cgi?id=39446
> +		rdar://problem/7999794
> +		

TABS!


> +    CFDictionaryRef options = 0;
> +    // If CAImageQueue prerequisites are not satisfied, pass in visual context pixelbuffer
> +    // options which will instruct the visual context to generate CGImage compatible 
> +    // pixel buffers (i.e. RGBA).
> +    if (!requiredDllsAvailable() || preferredMode != MediaRenderingMovieLayer )

Extra space.

> +        options = QTMovieVisualContext::getCGImageOptions();
> +    m_visualContext = adoptRef(new QTMovieVisualContext(m_visualContextClient.get(), options));

This should use a create() method.

> +    m_visualContext->setMovie(m_movie.get());
>  }


>  QTMovieVisualContextPriv::~QTMovieVisualContextPriv()
>  {
> +	if (m_visualContext)
> +		QTVisualContextSetImageAvailableCallback(m_visualContext, 0, 0);
TABS!


Other than the nits. r=me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.