[Webkit-unassigned] [Bug 39744] New: qt_instance.cpp has coding-style errors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39744

           Summary: qt_instance.cpp has coding-style errors
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit Qt
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: agbakken at gmail.com


WebCore/bridge/qt/qt_instance.h:20:  #ifndef header guard has wrong style, please use: qt_instance_h  [build/header_guard] [5]
Total errors found: 1 in 1 files
dfb-47 [flow:~/dev/WebKit/WebCore/bridge/qt] ../../../WebKitTools/Scripts/check-webkit-style qt_instance.cpp 
WebCore/bridge/qt/qt_instance.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/bridge/qt/qt_instance.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/bridge/qt/qt_instance.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/bridge/qt/qt_instance.cpp:35:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/bridge/qt/qt_instance.cpp:37:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/bridge/qt/qt_instance.cpp:122:  Missing space before ( in foreach(  [whitespace/parens] [5]
WebCore/bridge/qt/qt_instance.cpp:155:  Missing space before ( in for(  [whitespace/parens] [5]
WebCore/bridge/qt/qt_instance.cpp:192:  Missing space before ( in foreach(  [whitespace/parens] [5]
WebCore/bridge/qt/qt_instance.cpp:219:  Missing spaces around =  [whitespace/operators] [4]
WebCore/bridge/qt/qt_instance.cpp:223:  One line control clauses should not use braces.  [whitespace/braces] [4]
WebCore/bridge/qt/qt_instance.cpp:228:  Missing space before ( in foreach(  [whitespace/parens] [5]
WebCore/bridge/qt/qt_instance.cpp:230:  One line control clauses should not use braces.  [whitespace/braces] [4]
WebCore/bridge/qt/qt_instance.cpp:238:  One line control clauses should not use braces.  [whitespace/braces] [4]
WebCore/bridge/qt/qt_instance.cpp:284:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/bridge/qt/qt_instance.cpp:335:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
WebCore/bridge/qt/qt_instance.cpp:351:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 16 in 1 files

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.