[Webkit-unassigned] [Bug 39357] [QT] QT_BEARER flag is not enabled on S60 properly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39357


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hausmann at webkit.org




--- Comment #6 from Simon Hausmann <hausmann at webkit.org>  2010-05-26 04:38:36 PST ---
(In reply to comment #4)
> (From update of attachment 56488 [details])
> >  !CONFIG(QTDIR_build):!contains(DEFINES, ENABLE_QT_BEARER=.) {
> > -    symbian: {
> > -        exists($${EPOCROOT}epoc32/release/winscw/udeb/QtBearer.lib)| \
> > -        exists($${EPOCROOT}epoc32/release/armv5/lib/QtBearer.lib) {
> > -            DEFINES += ENABLE_QT_BEARER=1
> > -        }
> 
> I find this existing build logic useful to continue building WebKit trunk for Symbian devices with QtNetwork 4.6 and a separate QtBearer module. We can maybe add an extra guard around this logic to state explicitly that this only make sense if Qt version is less than 4.7, but I prefer not to remove this code.

The problem with the existing logic is that it breaks the build in this setup:

    1) Symbian^3 (coming with Qt and the bearer libs in the above location)
    2) You compile Qt yourself (in say \dev\myqt)
    3) Then you try to compile WebKit and it thinks that Qt is configured with mobility support, which it actually isn't.

I think Mahesh's detection is correct here.

> > +    exists($$[QMAKE_MKSPECS]/features/mobility.prf) {
> > +       DEFINES += ENABLE_QT_BEARER=1
> >      }
> 
> This might make sense for other QtMobility modules (like Geolocation), but it does not make sense to me for BearerMgmt as BearerMgmt is being rolled into QtNetwork and it will not be a separate QtMobility module going forward.
> 
> We should check for Qt version to see if QtNetwork module supports BearerMgmt, but that is already part of the build system.

Right, we do that already below. But shouldn't we keep the existing support for Qt 4.6 + bearer management around, too, for Symbian^3?

I'd like to refine the existing check to work better (more reliable and cross-platform) and I think we should use the same check in general for future modules provided by the Qt Mobility project.

> # Bearer management is part of Qt 4.7
> !lessThan(QT_MINOR_VERSION, 7):!contains(DEFINES, ENABLE_QT_BEARER=.):DEFINES += ENABLE_QT_BEARER=1
> 
> r- for taking this feature discovery approach for BearerMgmt; this will make more sense to mo for other QtMobility modules (e.g. Geolocation).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.