[Webkit-unassigned] [Bug 39092] Chromium/Mac: Add support for yank (ctrl-y)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39092


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57075|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #10 from Eric Seidel <eric at webkit.org>  2010-05-26 01:11:16 PST ---
(From update of attachment 57075)
We don't need this to be run-time switchable.  So we should just make KillRing.h non-virtual declarations and then add a KillRingNone.cpp which is used by every non-mac port and has empty implementations.

We could also just use a killRing() helper function in KillRing.h which returns a function-level static KillRing; which would then effectively be the killring.

Using a global function to access the killring like that makes mocking harder... but we don't really have C++ unit testing in WebCore anyway.  It would get rid of the need to have any #ifdefs in editor since everywhere would just call killRing() like it does now, but that would be a global function returning the global killring object.

Otherwise this patch looks FANTASTIC. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.