[Webkit-unassigned] [Bug 38844] [GTK] Add support for DOM events in the GObject DOM bindings

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 25 21:48:21 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=38844


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55698|review?                     |review-
               Flag|                            |




--- Comment #10 from Gustavo Noronha (kov) <gns at gnome.org>  2010-05-25 21:48:20 PST ---
(From update of attachment 55698)
 56     g_idle_add((GSourceFunc)finish_loading, fixture);
 57     g_main_loop_run(fixture->loop);

Why are you doing this here? I would expect the string to be loaded synchronously, as it is now. Also, I think this test is lacking an assertion that fixture->counter has been incremented at all. I don't think this test is really testing what it's supposed to test, so I'll r-.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list