[Webkit-unassigned] [Bug 38844] [GTK] Add support for DOM events in the GObject DOM bindings
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 25 21:38:24 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=38844
Gustavo Noronha (kov) <gns at gnome.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #55687|review? |review+
Flag| |
--- Comment #8 from Gustavo Noronha (kov) <gns at gnome.org> 2010-05-25 21:38:23 PST ---
(From update of attachment 55687)
WebCore/bindings/gobject/GObjectEventListener.h:31
+ static PassRefPtr<GObjectEventListener> create(GObject* object, const char* signalName) { return adoptRef(new GObjectEventListener(object, signalName)); }
Indentation looks weird here.
WebCore/bindings/gobject/GObjectEventListener.h:49
+ virtual void handleEvent(ScriptExecutionContext*, Event*); /* */
What's the /* */ for? =)
WebCore/bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:184
+
One too many empty lines here, for my taste.
A good first step IMO. And good improvement on style conformance, too.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list