[Webkit-unassigned] [Bug 39690] New: check-webkit-style incorrect if patch is only deletes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39690

           Summary: check-webkit-style incorrect if patch is only deletes
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ojan at chromium.org
                CC: eric at webkit.org, cjerdonek at webkit.org


Make a patch with only deletes and run check-webkit-style.

I get this output

$ check-webkit-style --git-commit head --verbose
webkitpy.common.system.logutils: DEBUG    Debug logging enabled.
check-webkit-style: DEBUG    Verbose logging enabled.
webkitpy.common.system: DEBUG    "git rev-parse --is-inside-work-tree" took 0.01s
webkitpy.common.system: DEBUG    "git rev-parse --git-dir" took 0.01s
check-webkit-style: DEBUG    WebKit checkout found with root: /WebKit/
webkitpy.style.main: DEBUG    Changing to checkout root: /WebKit/
webkitpy.common.system: DEBUG    "git diff --binary --no-ext-diff --full-index -M head^..head" took 0.02s
webkitpy.style.patchreader: DEBUG    Found 0 new or modified lines in: WebKitTools/Scripts/webkitpy/common/net/rietveld.py
check-webkit-style: INFO     Total errors found: 0 in 0 files

The bug is in patchreader.py. It only checks style on files that have modified/new lines. That part makes sense. But since it doesn't call process_file, the test_file_reader thinks that no files were checked.

This means that check-webkit-style errors out and webkit-patch upload prompts whether to continue.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.