[Webkit-unassigned] [Bug 39433] editingBehavior settings needs to be set back to a reasonable default between tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39433





--- Comment #25 from Ojan Vafai <ojan at chromium.org>  2010-05-25 13:10:50 PST ---
(In reply to comment #23)
> > I wouldn't want DRT always defaulting to EditingMacBehavior because then we lose test coverage.
> 
> I disagree with that. We need reproducible results more than we need accidental testing - running tests on Mac should be as close to running them on other platforms as possible.

If a test fails on Windows because of the editing behavior, then one of two things should happen:
1. There's a bug when using EditingWinBehavior and that should be fixed.
2. The test unintentionally is testing platform-specific behavior and the test should be fixed to test both EditingMacBehavior and EditingWinBehavior.

As long as the above happens, running tests from a Mac is fairly close to running them on other platforms. A given commit might cause a failure on a non-mac port, but the fix will mean broader test coverage. We have bots specifically to ensure that the port-specific code is tested. I don't see why it makes sense for platform-specific code to not get the same testing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.