[Webkit-unassigned] [Bug 36037] REGRESSION(51522): typing at the end of a line in designMode documents is *very* slow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36037





--- Comment #23 from Enrica Casucci <enrica at apple.com>  2010-05-25 12:29:11 PST ---
(In reply to comment #21)
> (In reply to comment #19)
> > (In reply to comment #18)
> > > It seems there are more fixes in attachment 54101 [details] [details] [details] which we should eventually make in PositionIterator.
> > 
> > I'm not sure I agree. That patch broke a number of tests and some crashed. The behavior of increment is correct, what was wrong was the behavior of decrement that was causing to iterate over the wrong positions.
> > I don't think there is anything wrong with the intended behavior of PositionIterator, there was just a bug in the implementation.
> 
> PositionIterator should iterate over all possible Positions, right? I don't think increment does currently. It just doesn't happen to hit in this case. The code in attachment 54101 [details] may well have been wrong, but I'm pretty sure the existing increment implementation skips over some positions. Unless you think I'm wrong, I think it deserves a FIXME.

I'll be happy to look into this while this is still fresh in my mind. Do you have an example of a case where increment skips positions? Keep in mind that m_anchorNode and m_offsetInAnchor only represent the current iterator position. To get the real position we need to use the Position() operator.
Moreover lastOffsetForEditing calls editingIgnoresContent internally to skip some positions on purpose.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.