[Webkit-unassigned] [Bug 39557] Full screen doesn't work for video elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39557





--- Comment #35 from Jer Noble <jer.noble at apple.com>  2010-05-25 11:36:42 PST ---
(In reply to comment #34)
> (In reply to comment #33)
> > (In reply to comment #31)
> > That said, I'm going to try doing and early return and discover what the corner case is and see if I can correct it.
> 
> Sorry, what I meant to say was: "I think it would be a little nicer if you reversed this if and made it into an early return, like this:
> 
> if (!m_rootChild)
>     return;

That makes way more sense.  Consider it done.

> > > > +    case WM_PAINT:
> > > > +        m_layerRenderer->renderSoon();
> > > > +        break;
> > > > +    }
> > > 
> > > Why do we only render soon, rather than immediately?
> > 
> > Because both the render() and paint() functions are declared as private.  Is it worth moving one of those into public?
> 
> Ah, interesting. I think making paint() public would be OK. You should talk to Chris, though, since he made that decision.

Will do.

> > > > +HWND FullscreenVideoController::parentHWND()
> > > > +{
> > > > +    if (m_mediaElement) {
> > > > +        WebView* webView = kit(m_mediaElement->document()->page());
> > > > +        if (webView)
> > > > +            return webView->topLevelParent();
> > > 
> > > Why not use the WebView's HWND? That way the fullscreen window will disappear if the user switches tabs.
> > 
> > An excellent idea.  Oh wait, this doesn't really jive with passing the HWND into the FullscreenLayerWindow's constructor.  Hm.  A conundrum.  I think I prefer the m_client->parentHWND() technique.
> 
> Why does using the WebView's HWND not make it possible to pass the HWND to the constructor?

Because here we are getting the WebView by way of the media element, and the media element is given to the FullscreenVideoController after it's been constructed, so at construct time, we'll have no HWND to give.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.