[Webkit-unassigned] [Bug 39490] Indexed Database component is missing IDBObjectStoreRequest interface

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39490





--- Comment #11 from Andrei Popescu <andreip at google.com>  2010-05-25 11:02:42 PST ---
(In reply to comment #7)
> (From update of attachment 56902 [details])
> WebCore/storage/IDBAny.h:84
>  +  
> extra new line
> 

Removed.

> WebCore/storage/IDBObjectStore.cpp:28
>  +  #include "config.h"
> new line between */ and this
>

Added.

> WebCore/storage/IDBObjectStore.cpp:2
>  +   * Copyright (C) 2010 Google Inc. All rights reserved.
> For new files, lets use this: http://webkit.org/coding/bsd-license.html
>

Hmm, there was a 3rd clause in my license, otherwise it was the same. Removed.


> WebCore/storage/IDBObjectStore.h:2
>  +   * Copyright (C) 2010 Google Inc. All rights reserved.
> ditto
> 
> WebCore/storage/IDBObjectStore.h:39
>  +  // This class is shared by IDBObjectStoreRequest (async) and IDBObjectStoreSync (sync).
> not sure if this is necessary.  We document this relationship for IndexedDatabase so, if anything, maybe we should point the reader in that direction?
>

I removed it, not sure the comment added any value.

> WebCore/storage/IDBObjectStore.h:44
>  +          return adoptRef(new IDBObjectStore);
> It doesn't matter, but () seems prettier maybe?  (In some cases, () implies that it should be 0 initialized so it seems like a good habit?)
>

Ok.

> WebCore/storage/IDBObjectStore.h:46
>  +      virtual ~IDBObjectStore() { }
> Don't think this needs to be virtual.  (If you copied this from elsewhere, you can probably change it there too if you want.)
> 
> WebCore/storage/IDBObjectStoreRequest.cpp:2
>  +   * Copyright (C) 2010 Google Inc. All rights reserved.
> ditto...ditto
> 
> WebCore/storage/IDBObjectStoreRequest.cpp:41
>  +      : m_objectStore(idbStore)
> Nit, order the variables the same in the constructor and the class
>


Hmm, but they are in order already...objectStore is first in the header. Or am I misunderstanding you?


> WebCore/storage/IDBObjectStoreRequest.h:64
>  +      PassRefPtr<IDBRequest> addOrModify(PassRefPtr<SerializedScriptValue> value, PassRefPtr<SerializedScriptValue> key);
> Will it compile if you make "0" a default value for the key parameter?
> 

Yes, done.

Thanks,
Andrei

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.