[Webkit-unassigned] [Bug 39433] editingBehavior settings needs to be set back to a reasonable default between tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39433


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ojan at chromium.org




--- Comment #22 from Ojan Vafai <ojan at chromium.org>  2010-05-25 09:12:01 PST ---
(In reply to comment #10)
> +        editingBehavior settings needs to be set back to a reasonable default between tests
> 
> FWIW, I'd expect "reasonable default" to be the same on all platforms. What's the value in making it different?

For non-DRT, the code in Settings.cpp currently has a different default for Mac and everyone else. So, DRT should, at reset the value to that default. I wouldn't want DRT always defaulting to EditingMacBehavior because then we lose test coverage. For example, if someone accidentally modifies the EditingWinBehavior behavior, then only the tests that call setEditingBehavior would actually test that.

I think it's unfortunate that we have setEditingBehavior calls littered throughout the code though. I'd prefer that we had Settings::resetEditingBehavior or Settings::defaultEditingBehavior so that we have the logic of which editing behavior to use in one place. Eric pushed back on this on #webkit saying that this would be different than all other DRT setters. I don't have enough experience hacking on DRT to say.

(In reply to comment #12)
> How many tests like that are there? What we basically need is make two or three copies of each, and set different behaviors in those.

Now that we've exposed setEditingBehavior, we can modify those tests to test both EditingMacBehavior and EditingWinBehavior. There's no need for them to have platform specific expectations now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.