[Webkit-unassigned] [Bug 39490] Indexed Database component is missing IDBObjectStoreRequest interface

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39490





--- Comment #7 from Jeremy Orlow <jorlow at chromium.org>  2010-05-25 06:42:12 PST ---
(From update of attachment 56902)
WebCore/storage/IDBAny.h:84
 +  
extra new line

WebCore/storage/IDBObjectStore.cpp:28
 +  #include "config.h"
new line between */ and this

WebCore/storage/IDBObjectStore.cpp:2
 +   * Copyright (C) 2010 Google Inc. All rights reserved.
For new files, lets use this: http://webkit.org/coding/bsd-license.html

WebCore/storage/IDBObjectStore.h:2
 +   * Copyright (C) 2010 Google Inc. All rights reserved.
ditto

WebCore/storage/IDBObjectStore.h:39
 +  // This class is shared by IDBObjectStoreRequest (async) and IDBObjectStoreSync (sync).
not sure if this is necessary.  We document this relationship for IndexedDatabase so, if anything, maybe we should point the reader in that direction?

WebCore/storage/IDBObjectStore.h:44
 +          return adoptRef(new IDBObjectStore);
It doesn't matter, but () seems prettier maybe?  (In some cases, () implies that it should be 0 initialized so it seems like a good habit?)

WebCore/storage/IDBObjectStore.h:46
 +      virtual ~IDBObjectStore() { }
Don't think this needs to be virtual.  (If you copied this from elsewhere, you can probably change it there too if you want.)

WebCore/storage/IDBObjectStoreRequest.cpp:2
 +   * Copyright (C) 2010 Google Inc. All rights reserved.
ditto...ditto

WebCore/storage/IDBObjectStoreRequest.cpp:41
 +      : m_objectStore(idbStore)
Nit, order the variables the same in the constructor and the class

WebCore/storage/IDBObjectStoreRequest.h:64
 +      PassRefPtr<IDBRequest> addOrModify(PassRefPtr<SerializedScriptValue> value, PassRefPtr<SerializedScriptValue> key);
Will it compile if you make "0" a default value for the key parameter?

WebCore/storage/IDBObjectStoreRequest.idl:37
 +          IDBRequest add(in SerializedScriptValue value, in [Optional] SerializedScriptValue key);
Oh, so optional does work now.  Cool!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.