[Webkit-unassigned] [Bug 39427] Increase limit on number of (i)frames from 200 to 1000.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39427





--- Comment #16 from hans at chromium.org  2010-05-25 04:05:31 PST ---
Thanks for the input.

(In reply to comment #15)
> (From update of attachment 56899 [details])
> WebCore/page/Page.h:240
>  +          static const int m_maxNbrOfFrames = 1000;
> style nit: spell out words and reserve m_ for private members:
> m_maxNbrOfFrames -> maxNumberOfFrames
Done.

> LayoutTests/compositing/iframes/too-many-objects.html:9
>  +    var created_objects = 0;
> nit: use camelCase for variables
Done.

> LayoutTests/compositing/iframes/too-many-objects.html:26
>  +    {
> nit: be consistent with braces
Done.

> LayoutTests/compositing/iframes/too-many-objects.html:25
>  +    function createIFrames(nbr)
> nit: avoid abbreviations like "nbr"
Done.

> nit: it seems like you could combine lots-of-iframes and too-many-iframes.
> lots-of-iframes is testing that you can create 1000 frames, and too-many-iframes
> is testing that once you have 1000 frames, you can't create one more.  they seem
> like they could just be part of a single test that asserts that 1000 is the limit
> for the number of tests you can create.  same goes for the object tag.
Done.

Uploading new patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.