[Webkit-unassigned] [Bug 39635] Improve canvas perf test fairness.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39635





--- Comment #4 from David Levin <levin at chromium.org>  2010-05-25 00:17:00 PST ---
>From last time, I remove the scale calls that I was sure were needed but apparently were not. (I must have made a mistake in the Javascript code with the context I was using when I hit this issue.)

I fixed a few issues in my last patch:

>  output.innerHTML += "Indirect copy with (via ImageData): " + (time/2) + "ms<br>";
                                                                                                                    ^^^^ the /2 shouldn't be here.


>     time = (new Date()) - startDate;
Old time calculation was present before the result for 0.5 scale.

>  time = timeCanvasOperation(scaledDownContext,
                                                       ^^^^ flushing the wrong context.
>          function () {
>              rotatedContext.drawImage(original, 0, -original.height);
>          });

As such the results changed to more accurately reflect perf, for Firefox 3.7a4
  Direct image copy: 96ms
  Indirect copy with (via ImageData): 346ms (No longer dividing by 2 when we shouldn't)
  Copy with 2x scale: 277ms (likely lower due to allowing garbage collection)
  Copy with 0.5x scale: 44ms (now calc'ing time correctly with subtracting out the overhead)
  Copy with rotate: 120 ms (now flushing the correct context)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.