[Webkit-unassigned] [Bug 39624] --squash should be replaced with --git-commit=*

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39624





--- Comment #4 from Ojan Vafai <ojan at chromium.org>  2010-05-24 16:04:15 PST ---
(In reply to comment #1)
> You shell will eat "*", seems like a poor choice of argument.

Hm. Yeah, this is kind of gross. "--git-commit=*" or "-g*" work, but "--git-commit *" and "-g *" don't. Any suggestions for alternatives? We want something simple that people can remember and that won't conflict with a commit/branch name.

> I guess I should go back and read the thread as to why --git-commit=* is better than --squash.

It makes things simpler both in terms of using webkit-patch and in terms of the underlying code. Much of this change is deleting code! In terms of webkit-patch use, it turns three mutually exclusive command-line flags into one. I think that will be much easier for people to wrap their heads around.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.