[Webkit-unassigned] [Bug 39571] Teach the HTML5 parser to lex DOCTYPEs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39571


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56923|review?                     |review-
               Flag|                            |




--- Comment #5 from Eric Seidel <eric at webkit.org>  2010-05-24 14:26:14 PST ---
(From update of attachment 56923)
WebCore/html/HTML5Lexer.cpp:891
 +                      source.advanceAndASSERTIgnoringCase('d');
Seems it would be simple to write a little helper method (static inline) which did:

static inline void advanceAndASSERTIgnoringCase(SegmentedString& string, char* assertionString)
{
    for (int x = 0;; x++) {
        if (!assertionString[x])
             return;
        string.advanceAndASSERTIngoringCase(assertionString[x]);
     }
}

That would read much cleaner in the callsites.

WebCore/html/HTML5TreeBuilder.cpp:100
 +      if (token.type() == HTML5Token::Uninitialized)
This seems wrong.

WebCore/platform/text/SegmentedString.h:154
 +      void advanceAndASSERTIgnoringCase(UChar expectedCharacter)
We may just want to turn this into a static inline in HTML5Lexer.cpp instead.

I think we need one more round.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.