[Webkit-unassigned] [Bug 15720] [Transforms] Pixel cracks in scaled border-image

Mon May 24 13:55:53 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=15720

Beth Dakin <bdakin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56920|review?                     |review-
               Flag|                            |

--- Comment #7 from Beth Dakin <bdakin at apple.com>  2010-05-24 13:55:53 PST ---
(From update of attachment 56920)
I don't like the idea of GraphicsContext having two new implementations of drawTiledImage() that are copies of the existing implementations except that they take FloatRects instead of IntRects. That is a lot of code duplication, which is something we try to avoid. The GraphicsContext::drawImage() functions do a better job of sharing code. I suggest taking a look at them and devising a way to share as much code as possible.

Also, right now we only call roundToDevicePixels() from graphics-centric code…in other words, this would be the first patch where we called into that function directly from the render tree. I wonder if that is a separation that we want to maintain or not. It might be worth considering having drawTiledImage() call roundToDevicePixels() on the FloatRect rather than doing that at the call sites. 

I would be interested to see if Hyatt, Dan, or Darin has an opinion too :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.