[Webkit-unassigned] [Bug 39427] Increase limit on number of (i)frames from 200 to 1000.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39427





--- Comment #13 from hans at chromium.org  2010-05-24 10:01:03 PST ---
The check in RenderEmbeddedObject::isURLAllowed() was introduced in http://trac.webkit.org/changeset/11162. (That code has since migrated through revisions r11966, r12155, r14334 and r52947.)

The way I read that ChangeLog is that depending on the circumstances, there were code paths where the other check for number of frames (the one introduced in r3707) was circumvented, and this was a fix for that. As I understand it, it does the same check and has the same purpose as in HTMLFrameElementBase::isURLAllowed().

Eric and Maciej wrote and reviewed that patch. Perhaps they can shed some light on it?

What would have been "broken" by increasing the limit in HTMLFrameElementBase::isURLAllowed() and not in RenderEmbeddedObject::isURLAllowed() is that a page would be able to have 200+ iframes, but not 200+ embedded objects.

Uploading new patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.