[Webkit-unassigned] [Bug 39577] Improve HTML5 <video> tag performance

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39577





--- Comment #12 from Chris Marrin <cmarrin at apple.com>  2010-05-24 07:32:13 PST ---
(From update of attachment 56860)
WebCore/WebCore.vcproj/WebCore.vcproj:44112
 +          <Filter
This looks like a spurious change to the vcproj file. It's best to avoid checking them in. I've had success reverting the vcproj and then hand editing it to add the lines needed.

WebCore/WebCore.vcproj/WebCore.vcproj:44111
 +          </Filter>
This looks like a spurious change to the vcproj file. It's best to avoid checking them in. I've had success reverting the vcproj and then hand editing it to add the lines needed.

WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:683
 +      retrieveCurrentImage();
Why the change in indenting?

WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:766
 +          if (!buffer.lockBaseAddress()) {
More indenting changes?

WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:775
 +                  // Debug QuickTime links against a non-Debug version of CoreFoundation, so the CFDictionary attached to the CVPixelBuffer cannot be directly passed on into the CAImageQueue without being converted to a non-Debug CFDictionary.  Additionally, old versions of QuickTime used a non-AAS CoreFoundation, so the types are not interchangable even in the release case.
This comment should be split onto multiple lines

WebCore/platform/graphics/win/WKCACFLayer.cpp:507
 +          }
It would be nice if we could print something no matter what the type. Do we know all the types this could possibly return, or is there a way to go from CFTypeID to a string describing the type? Even if it just said ImageQueue without any additional info, it would be useful

WebCore/platform/graphics/win/WKCACFLayer.h:209
 +      CFTimeInterval speed() const { return CACFLayerGetSpeed(layer()); }
Weird. How did this ever compile? Oh, I know how. We never use this function so it never did compile! Thanks for finding it.

WebCore/platform/graphics/win/WKCAImageQueue.cpp:51
 +  }
What are these for? I don't see them being used anywhere

WebCore/platform/graphics/win/WKCAImageQueue.h:63
 +      };
I think the WebKit style is to not prefix enumerants like this.

WebCore/platform/graphics/win/WKCAImageQueue.h:74
 +      uint32_t height();
These can be const

WebCore/platform/graphics/win/WKCAImageQueue.h:77
 +      uint32_t capacity();
This can be const

WebCore/platform/graphics/win/WKCAImageQueue.h:85
 +      uint32_t flags();
This can be const

WebKitLibraries/win/include/WebKitSystemInterface/WebKitSystemInterface.h:123
 +  };
No prefixes needed here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.