[Webkit-unassigned] [Bug 39207] webkit-patch upload needs to pass diff to check-webkit-style

Mon May 24 02:20:36 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=39207

Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56854|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |

--- Comment #4 from Adam Barth <abarth at webkit.org>  2010-05-24 02:20:35 PST ---
(From update of attachment 56854)
The invalidation question below is important or else we could upload the wrong diff.

WebKitTools/Scripts/webkitpy/tool/steps/abstractstep.py: 
 +          command = [port.script_path(script_name)]
This seems unrelated, but ok.

WebKitTools/Scripts/webkitpy/tool/steps/checkstyle.py:52
 +          diff = self.cached_lookup(state, "diff")
Please make sure that prepare change log and edit change log correctly invalidate the diff.  I'm not sure if this really saves much since we need to recompute the diff after editing the change log anyway.  We need to track the modified files.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.