[Webkit-unassigned] [Bug 39584] New: webkit-patch land calls scm.create_patch 4 times!

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39584

           Summary: webkit-patch land calls scm.create_patch 4 times!
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
                CC: mjs at apple.com, abarth at webkit.org, ojan at google.com,
                    cjerdonek at webkit.org


webkit-patch land calls scm.create_patch 4 times!

webkit-patch land --verbose will show you:

webkitpy.common.system: [DEBUG] "git rev-parse --is-inside-work-tree" took 0.09s
webkitpy.common.system: [DEBUG] "git rev-parse --git-dir" took 0.01s
webkitpy.common.system: [DEBUG] "git config webkit-patch.squash" took 0.01s
webkitpy.common.system: [DEBUG] "git log --pretty=oneline HEAD...trunk" took 0.23s
webkitpy.common.system: [DEBUG] "git diff -r --name-status -C -M --no-ext-diff --full-index HEAD" took 26.24s
Parsing ChangeLog: /Projects/WebKit/WebKitTools/ChangeLog
Fetching: https://bugs.webkit.org/show_bug.cgi?id=39208&ctype=xml
Guessing "Chris Jerdonek" as reviewer from attachment 56222 on bug 39208.
webkitpy.common.system: [DEBUG] "git config webkit-patch.squash" took 0.09s
webkitpy.common.system: [DEBUG] "git log --pretty=oneline HEAD...trunk" took 0.21s
webkitpy.common.system: [DEBUG] "git diff -r --name-status -C -M --no-ext-diff --full-index HEAD" took 26.59s
webkitpy.common.system: [DEBUG] "git config webkit-patch.squash" took 0.31s
webkitpy.common.system: [DEBUG] "git log --pretty=oneline HEAD...trunk" took 0.34s
webkitpy.common.system: [DEBUG] "git diff -r --name-status -C -M --no-ext-diff --full-index HEAD" took 26.57s
Parsing ChangeLog: /Projects/WebKit/WebKitTools/ChangeLog
webkitpy.common.system: [DEBUG] "git config webkit-patch.squash" took 0.14s
webkitpy.common.system: [DEBUG] "git log --pretty=oneline HEAD...trunk" took 0.39s
webkitpy.common.system: [DEBUG] "git diff HEAD --name-only" took 28.41s
webkitpy.common.system: [DEBUG] "git log --pretty=oneline HEAD...trunk" took 0.29s
webkitpy.common.system: [DEBUG] "git commit --all -F -" took 40.12s


Notice that the I spent nearly 2 minutes waiting for it to run the same diff command 4 times!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.