[Webkit-unassigned] [Bug 39494] Change filenameFromString to return CString

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 23 20:14:22 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=39494





--- Comment #6 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-05-23 20:14:22 PST ---
Attachment 56844 did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/platform/gtk/FileSystemGtk.cpp:102:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/platform/gtk/FileSystemGtk.cpp:113:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/platform/gtk/FileSystemGtk.cpp:208:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 3 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list