[Webkit-unassigned] [Bug 39537] Teach HTML5 parser how to lex comments correctly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39537


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56831|review?                     |review+
               Flag|                            |




--- Comment #6 from Eric Seidel <eric at webkit.org>  2010-05-23 14:57:08 PST ---
(From update of attachment 56831)
WebCore/html/HTML5Token.h:159
 +          return cachedData();
cachedDataString()?

WebCore/html/HTML5Tokenizer.cpp:46
 +      case HTML5Token::EndOfFile:
Sooooo much better!

WebCore/platform/text/SegmentedString.h:135
 +      void advanceAndASSERT(UChar expectedCharacter)
This will fail in RElease builds.  We need UNUSED_PARAM I think.

Otherwise looks OK.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.