[Webkit-unassigned] [Bug 39525] Make HTML5 parser parse <script>alert("<hi>"); </script>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39525


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56779|review?                     |review+
               Flag|                            |




--- Comment #5 from Eric Seidel <eric at webkit.org>  2010-05-23 13:12:16 PST ---
(From update of attachment 56779)
WebCore/html/HTML5Lexer.cpp:225
 +          m_bufferedEndTagName.clear();
This seems like a temporary hack we should remove.

WebCore/html/HTML5Lexer.cpp:331
 +                  emitCurrentToken();
Seems strange that we don't return right after this call.  Do we have asserts in emitCurrentToken that we haven't already emitted?

WebCore/html/HTML5Lexer.cpp:1264
 +          if (actual[i] != appropriate[i])
Doesn't a UChar buffer compare method exist already?  Or shouldn't we make this into one?

WebCore/html/HTML5Token.h:128
 +              m_cachedName = AtomicString(StringImpl::adopt(m_data));
This is a good change. :)


Please conisder above comments.  This seems less than perfect but moves us forward.  100% correctness first, then several rounds of bathing are needed. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.