[Webkit-unassigned] [Bug 39551] New: Make parseDiff use $_ instead of $line for the current line

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 22 17:33:57 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=39551

           Summary: Make parseDiff use $_ instead of $line for the current
                    line
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: dbates at webkit.org
                CC: eric at webkit.org, cjerdonek at webkit.org


We can write "$line =~ $gitDiffStartRegEx" as "/$gitDiffStartRegEx/" and "$line !~ $headerStartRegEx" as "!/$headerStartRegEx/" in parseDiff. This matches the style we have been using in parseSvnDiffHeader, parseGitDiffHeader, parseSvnDiffProperties, parseSvnProperty, and parseSvnPropertyValue.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list