[Webkit-unassigned] [Bug 30802] Implement automatic switching to slider-vertical

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30802


Jakub Wieczorek <jwieczorek at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jwieczorek at webkit.org




--- Comment #4 from Jakub Wieczorek <jwieczorek at webkit.org>  2010-05-22 15:02:24 PST ---
> diff --git a/WebCore/rendering/RenderTheme.cpp b/WebCore/rendering/RenderTheme.cpp
> index 445e637bf2d703fee9f5dc27d3b06e71335bff5d..baa8d7cde1c55fc122236f21b044b7a0fa92d42d 100644
> --- a/WebCore/rendering/RenderTheme.cpp
> +++ b/WebCore/rendering/RenderTheme.cpp
> @@ -962,8 +962,10 @@ void RenderTheme::adjustMenuListButtonStyle(CSSStyleSelector*, RenderStyle*, Ele
>  {
>  }
>  
> -void RenderTheme::adjustSliderTrackStyle(CSSStyleSelector*, RenderStyle*, Element*) const
> +void RenderTheme::adjustSliderTrackStyle(CSSStyleSelector*, RenderStyle* style, Element*) const
>  {
> +    if (style->height().isFixed() && style->width().isFixed() && style->height().value() > style->width().value())
> +        style->setAppearance(SliderVerticalPart);
>  }
>  
>  void RenderTheme::adjustSliderThumbStyle(CSSStyleSelector*, RenderStyle*, Element*) const
> diff --git a/WebCore/rendering/RenderThemeMac.mm b/WebCore/rendering/RenderThemeMac.mm
> index f1de7759e85349b948d2e4d445e22bd88f844de3..ca69babdb25f6d38279f4d362aed964f0e0e4b68 100644
> --- a/WebCore/rendering/RenderThemeMac.mm
> +++ b/WebCore/rendering/RenderThemeMac.mm
> @@ -1150,8 +1150,9 @@ int RenderThemeMac::minimumMenuListSize(RenderStyle* style) const
>  const int trackWidth = 5;
>  const int trackRadius = 2;
>  
> -void RenderThemeMac::adjustSliderTrackStyle(CSSStyleSelector*, RenderStyle* style, Element*) const
> +void RenderThemeMac::adjustSliderTrackStyle(CSSStyleSelector* selector, RenderStyle* style, Element* element) const
>  {
> +    RenderTheme::adjustSliderTrackStyle(selector, style, element);
>      style->setBoxShadow(0);
>  }
>  

The Qt port also reimplements this function (in WebCore/platform/qt/RenderThemeQt.cpp), hence it should call the base one too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.