[Webkit-unassigned] [Bug 39465] [GTK] webkit_web_view_drag_end should call EventHandler::dragSourceEndedAt

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39465


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56656|review?                     |review-
               Flag|                            |




--- Comment #2 from Xan Lopez <xan.lopez at gmail.com>  2010-05-22 01:42:47 PST ---
(From update of attachment 56656)
>+        [GTK] webkit_web_view_drag_end should call EventHandler::dragSourceEndedAt
>+        https://bugs.webkit.org/show_bug.cgi?id=39465

Why should it call it? What happens if you don't? Just because of the names it makes sense, but we should explain it in the ChangeLog.

>+    event->button.window = static_cast<GdkWindow*>(g_object_ref(
>+        gdk_display_get_window_at_pointer(display, &x, &y)));

I think the style is to let lines be as long as needed.

>+    event->button.x = x;
>+    event->button.y = y;
>+    event->button.x_root = xRoot;
>+    event->button.y_root = yRoot;
>+    event->button.state = modifiers;
>+
>+    PlatformMouseEvent platformEvent(&event->button);
>+    frame->eventHandler()->dragSourceEndedAt(platformEvent,
>+        gdkDragActionToDragOperation(context->action));

Same.

r- for missing rationale and because I'm feeling evil.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.