[Webkit-unassigned] [Bug 38213] Page up / page down moves edited content for the entire height

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38213


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56740|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #33 from Ojan Vafai <ojan at chromium.org>  2010-05-21 13:31:13 PST ---
(From update of attachment 56740)
r=me with the change below. Thanks for being patient with all this.

WebCore/editing/SelectionController.cpp:174
 +          if (macStyleScroll)
If settings is null, that means we're in a state where it doesn't matter what editing behavior we use (e.g. a page transition). The null check is just to avoid crashing. So you can get rid of the macStyleScroll variable and just do something like this:
if (m_frame->settings() && m_frame->settings()->editingBehavior() == EditingMacBehavior)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.