[Webkit-unassigned] [Bug 39494] Change filenameFromString to return CString

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39494





--- Comment #3 from Darin Adler <darin at apple.com>  2010-05-21 11:16:46 PST ---
(From update of attachment 56720)
Good change!

> -char* filenameFromString(const String&);
> +WTF::CString filenameFromString(const String&);

Just CString should be fine, no need for the "WTF::" prefix here.

I can't tell whether filenameFromString is allowed to return the null string or not. If it is allowed to return null, it seems that many call sites are missing code to handle this case and will crash. If it is not allowed to return null, then some call sites have extra unneeded code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.