[Webkit-unassigned] [Bug 39495] All callable objects should have a global object reference

Fri May 21 10:54:49 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=39495

Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56726|review?                     |review+
               Flag|                            |

--- Comment #2 from Geoffrey Garen <ggaren at apple.com>  2010-05-21 10:54:49 PST ---
(From update of attachment 56726)
Please mention your performance testing results in the ChangeLog.

+        All objects that may ever return a value other CallTypeNone
+        or ConstructTypeNone now get a global object in their constructor

Typo: Should be "other than".

Please fix EWS failures.

Since we can't use C++ subclassing, I wonder if there's some other centralized choke-point we can use for ensuring our anonymous slot contract. The ASSERT is good, but it would be better to catch an error even earlier, like at object construction time. For example, maybe we need a Structure::createCallable.

r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.