[Webkit-unassigned] [Bug 39427] Increase limit on number of (i)frames from 200 to 1000.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39427


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56596|review?                     |review-
               Flag|                            |




--- Comment #11 from Alexey Proskuryakov <ap at webkit.org>  2010-05-21 09:23:23 PST ---
(From update of attachment 56596)
> RenderEmbeddedObject::isURLAllowed() looks to see if 
> Page::frameCount() is < 200. It seems to me that it should use the
> same limit as HTMLFrameElementBase.

I don't know what this check is about, but it definitely seems so! Now I wonder what was broken due to not having it fixed, too. Ideally, we would have a test case that fails with the current version of your patch, but not with a final one.

> One idea would be to raise the limit to 1111 frames

Having a round number like 999, 1000, or 2000 is better in that it's easier to understand what's going on when we hit the limit.

Marking r- to get this out of review queue, since some modifications are clearly needed, as well as some investigation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.