[Webkit-unassigned] [Bug 39429] Add DOMStringList idl, needed for IndexedDB and for HTML5 drag & drop

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39429


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56699|review?                     |review-
               Flag|                            |




--- Comment #6 from Alexey Proskuryakov <ap at webkit.org>  2010-05-21 09:16:11 PST ---
(From update of attachment 56699)
+    void append(String string) { m_strings.append(string); }

"const String&"!

+    return 1 if $type eq "CSSStyleDeclaration" or $type eq "MediaList" or $type eq "CSSVariablesDeclaration" or $type eq "DOMStringList";

This always makes me sad - why do we have IDLs if we encode knowledge about specific classes into code generator. Not something to fix in this patch, of course.

+        No new tests since nothing uses this.  I'm happy to land it at the same time as
+        an IndexedDB change that uses this and adds a test, but IndexedDB is behind
+        a flag on all platforms besides chromium.  Another option is to put this
+        behind the INDEXED_DATABASE flag until there's another consumer of it.

I think that ChangeLog doesn't need a discussion of options you didn't take.

2) StaticStringList:

OK. I'd add a comment in DOMStringList.h explaining that the current implementation only accommodates the case when all the strings are known in advance. It could go right after "Implements the IDL" comment, which conveniently lacks an ending period - so you need to fix that line anyway!

3) DOMStringList.contains():

I see it in <http://www.w3.org/TR/DOM-Level-3-Core/core.html>. What's the newer version? The one you reference in ChangeLog is older, not newer.

We might actually need a better implementation of contains() than I had.

I'd prefer to have a quick look at the fixed code. Just curious - what time zone are you in?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.