[Webkit-unassigned] [Bug 39146] [Qt] Pass all web notification layout tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39146





--- Comment #13 from Simon Hausmann <hausmann at webkit.org>  2010-05-21 06:41:21 PST ---
(In reply to comment #12)
> (In reply to comment #11)
> > (From update of attachment 56523 [details] [details])
> > WebKit/qt/Api/qwebpage.cpp:1689
> >  +      connect(mainFrame(), SIGNAL(javaScriptWindowObjectCleared()), d->notificationPresenterClient->d, SLOT(clearNotificationsList()));
> > Why is clearNotificationsList() connected to this signal?
> When navigating to a new page we have to delete all the notifications of the current page, or we will have a memory leak.

Hm, so shouldn't this be done through a callback from say FrameLoader::clear() to FrameLoaderClient and then propagated to the notifications? Or perhaps WebCore should call NotificationPresenter::clear() or so directly?

Where do the other ports clear the notifications when a new page is loaded?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.