[Webkit-unassigned] [Bug 39483] Building Efl port fails

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39483


Adam Roben (aroben) <aroben at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56700|review?                     |review-
               Flag|                            |




--- Comment #1 from Adam Roben (aroben) <aroben at apple.com>  2010-05-21 05:58:17 PST ---
(From update of attachment 56700)
> @@ -76,7 +76,7 @@ SET(WebKit_LIBRARY_TYPE SHARED)
>  # Port-specific options
>  # -----------------------------------------------------------------------------
>  INCLUDE(OptionsCommon)
> -INCLUDE(Options${PORT})
> +INCLUDE(Options${PORT} OPTIONAL)

I didn't see any explanation of this change in your commit message.

The WebKit project uses ChangeLog files as well as commit messages to explain changes. You can use the prepare-ChangeLog script to add a skeleton ChangeLog entry to the appropriate file, and then you can edit the entry manually. We then use the ChangeLog entry as the commit message.

If you add a ChangeLog entry and explain the above change, I think we can get this landed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.