[Webkit-unassigned] [Bug 39429] Add DOMStringList idl, needed for IndexedDB and for HTML5 drag & drop

Fri May 21 04:45:10 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=39429

--- Comment #4 from Jeremy Orlow <jorlow at chromium.org>  2010-05-21 04:45:10 PST ---
Thanks a lot for the pointer, Alexey!  Sorry about forgetting the constructor.  Fixed now.

I noticed a couple differences between our code:
1) Custom bindings:  Thankfully, it looks as though these are no longer required for either V8 or JSC.
2) StaticStringList:  I could refactor my code to match what was originally there, but I guess I'm not sure I see a point at the moment.  My (yet to be uploaded) IndexedDB patch simply builds up the list on demand (as the actual objectStore and index data is stored in objects, not simply as a list of strings) with the add method.  I believe the standard procedure in cases like this is to keep it simple for now and let someone refactor later if something more complicated is necessary in the future.
3) DOMStringList.contains():  I double checked, but this is not in the latest version of the spec, so I have not included it.

Please take another look?

Given that we're in different time zones, if this patch is close, an "r+ with items to address before landing" would be greatly appreciated if nothing's too far off.

Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.