[Webkit-unassigned] [Bug 39440] [chromium] Adds Geolocation support to DumpRenderTree.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39440





--- Comment #4 from Marcus Bulach <bulach at chromium.org>  2010-05-21 03:43:10 PST ---
thanks Tamura-san!

replies inline:

(In reply to comment #2)
> (From update of attachment 56620 [details])
> Thank you for making the patch.
> WebKitTools/DumpRenderTree/chromium is not the primary tester yet.  You need to change webkit/tools/test_shell/ in Chromium too.

yep, the change has been reviewed and I'll submit it soon:
http://codereview.chromium.org/2094003/show

> 
> 
> WebKit/chromium/public/WebGeolocationServiceMock.h:55
>  +      static bool m_mockGeolocationPermission;
> We don't prepend "m_" for a static field in WebKit style.

Done.

> 
> 
> WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp:1303
>  +      WebGeolocationServiceMock::setMockGeolocationError(arguments[0].toInt32(), WebString::fromUTF8(arguments[1].toString()));
> nit: We have cppVariantToWebString().

ahn, thanks! I went ahead and replaced all occurrences so it won't catch the next reader.
however, please, let me know if you'd prefer to this tidy up in a separate patch, and I'd be happy to revert these changes.

would you mind taking another look? thanks!

> 
> 
> r- for the style error.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.